pal-e-docs

Review: Property detail page refresh: Projects button + CSS update

review-1351-2026-06-07 Review

review needs-refinement
Project

Verdict: NEEDS_REFINEMENT

Template Completeness

  • [x] Type -- Feature
  • [x] Lineage -- Present, references spike #121 and ServiceRequest dependency
  • [x] Repo -- Present
  • [x] User Story -- Present
  • [x] Context -- Present
  • [x] File Targets -- Present (4 files)
  • [ ] Feature Flag -- MISSING. Template requires this section. CSS/UI-only work qualifies for "none" but the section should be explicitly present.
  • [x] Acceptance Criteria -- Present (5 items)
  • [x] Test Expectations -- Present
  • [x] Constraints -- Present
  • [x] Checklist -- Present
  • [x] Related -- Present

Traceability

  • [x] story:auth label -- "auth" story found in project-landscaping-assistant user-stories table ("Log in with Keycloak, see role-appropriate tabs and features")
  • [x] story note verified -- found in project-landscaping-assistant user-stories section
  • [x] arch:rails-app label -- present
  • [x] arch note verified -- arch-rails-app note exists in pal-e-docs (scoped to pal-enterprises as a shared RoR architecture doc, acceptable for cross-project use)
  • [x] Forgejo issue -- #126, open

File Targets

  • [x] app/views/properties/show.html.erb -- verified: exists, contains detail-actions div with Update Address button, Go to Location link, Edit link (lines 28-36)
  • [x] app/assets/stylesheets/application.css -- verified: exists, has .detail-actions section at line 913 and .btn-link at line 929
  • [x] app/views/service_requests/_property_projects.html.erb -- correctly marked as new. NOTE: the app/views/service_requests/ directory does not yet exist and will need to be created
  • [x] spec/requests/properties_spec.rb -- verified: exists (9.1k)

Repo Placement

OK. Single repo (ldraney/landscaping-assistant), correctly filed on the same repo's Forgejo tracker.

Dependencies

  • HARD BLOCKER: Issue #122 (ServiceRequest model + migration, board item #1347) is still in backlog. The ServiceRequest model does not exist -- no model file, no migration, no service_requests table in db/schema.rb. This ticket's core functionality (Projects button showing active/completed projects from ServiceRequest where request_type = "project") cannot be implemented without it.
  • Issue #121 (parent spike: Design client request flow) -- done, no blocker.
  • Missing reference: ~/ror-css-guide is referenced in the issue body and acceptance criteria but does not exist as a pal-e-docs note (slug ror-css-guide returns 404). The agent will have no CSS guide to follow.

Acceptance Criteria

5 acceptance criteria. All are testable in principle, but criteria 2-4 (Projects button, projects section, project details with status/price) depend on the ServiceRequest model existing. Only AC #1 (CSS styling) and AC #5 (mobile touch targets) can be verified independently. Test command (bundle exec rspec) is real and works.

Blast Radius

Limited. Changes are confined to the property show page and its CSS. No sibling services share these stylesheets. No downstream consumers affected. The btn-link class is only used on the properties show page.

Decomposition Assessment

4 file targets in 1 repo, 5 AC. Single agent pass is feasible once the ServiceRequest dependency is resolved. No decomposition needed.

Recommendations

  • [BODY] Add Feature Flag section: ### Feature Flag\nnone (CSS/UI work, no flag needed)
  • [SCOPE] Hard dependency on #122 (ServiceRequest model + migration) must be resolved first. Either: (a) move #122 ahead of this ticket in priority, or (b) split this ticket into two: one for CSS-only refresh (no ServiceRequest dependency), one for Projects button (depends on #122).
  • [SCOPE] Create pal-e-docs note ror-css-guide with the CSS conventions for RoR apps (design tokens, mobile-first, single breakpoint at 600px, button treatment). The issue and AC reference it but it does not exist.