pal-e-docs

Review: Fix ServiceMonitor label mismatch

review-1291-2026-06-01 Review

review ready
Project

Verdict: READY

Template Completeness

  • [x] Type — Feature
  • [x] Lineage — standalone, observability audit
  • [x] Repo — ldraney/pal-e-deployments
  • [x] User Story — clear
  • [x] Context — explains label mismatch
  • [x] File Targets — bases/standard/kustomization.yaml, overlays/landscaping-assistant/prod/kustomization.yaml
  • [x] Acceptance Criteria — kustomize build shows correct labels
  • [x] Test Expectations — kustomize build + kubectl
  • [x] Constraints — depends on #19
  • [x] Checklist — present
  • [x] Related — parent #43

Traceability

  • [x] story:observability — on board item
  • [x] arch:k8s-deploy — on board item
  • [x] Forgejo issue #15 — open

File Targets

  • [x] bases/standard/kustomization.yaml — servicemonitor.yaml missing from resources
  • [x] overlays/landscaping-assistant/prod/kustomization.yaml — needs label patch

Repo Placement

Correct. pal-e-deployments owns kustomize overlays.

Dependencies

  • [ ] #19 /metrics endpoint — PENDING (PR #47 open)

Acceptance Criteria

Testable: kustomize build shows ServiceMonitor with correct labels. Prometheus targets page shows landscaping-assistant.

Blast Radius

Low. Only affects landscaping-assistant ServiceMonitor.

Decomposition Assessment

Two small changes in one repo. Under 5 minutes.

Recommendation

  • Execute after #19 merges.
  • Lower points from 2 to 1.