pal-e-docs

Review: westside-admin#29 (board 1146) — Edit route + audit — 2026-05-04 (v1, NEEDS_REFINEMENT minor)

review-1146-2026-05-04 Doc

review needs-refinement
Project

Scope Review: westside-admin#29 (board item 1146) — Players edit route + transactional audit

Verdict

NEEDS_REFINEMENT (minor) (refinements applied in body v2 on 2026-05-04; re-review pending). Forgejo comment issue #29 comment 16229 is the canonical record.

Three minor refinements

  • [BODY] GET-side leak check. Added explicit AC + integration test that contract_token value never appears in /players/:id HTML body. Existing WRITE-side guard (form excludes the column) was correct but didn't enforce READ-side.
  • [BODY] old_state / new_state shape. Pinned as full-row snapshots, not diffs, in Constraints. Removes ambiguity for the dev agent.
  • [SCOPE — non-blocker] arch-page-server backing note doesn't exist in pal-e-docs. Shared gap with #4 (board item 1092). Filed as a separate Ava task; thin pointer to arch-dataflow-westside-admin Flow 2 should suffice.

Other findings

  • Template completeness: all 11 template-issue-feature sections present.
  • Traceability: story:admin-row-crud backing note exists. arch:page-server backing absent (gap above). Behavior IS documented in arch-dataflow-westside-admin Flow 2.
  • File targets verified: all 4 Create paths greenfield in ~/westside-admin. Modify target (src/routes/players/+page.svelte) ships in #4 — modification only valid after #4 merges (already declared as hard-dep).
  • Dependencies: #1, #3, #4, #28 all open. Documented correctly in body. Cannot advance past todo until those clear.
  • Decomposition: 4 files, 11 AC. Already a decomposition (split-from #5 → #28 + #29). Hold; further splitting creates useless intermediate states.

Outage Note

Filed retroactively after 7-min pal-e-docs outage; Forgejo comment 16229 is the real-time PM record.

Re-review

Body v2 edits are minor refinements (3 small additions). Will dispatch a fresh review-ticket agent for confirmation; expect quick turnaround to APPROVED. Once APPROVED, file review-1146-2026-05-04-v2 note.
  • Forgejo issue: forgejo_admin/westside-admin#29
  • Board item: 1146 on board-westside-admin