Review: Tenant-scoped Drizzle query helper

Verdict: NEEDS_REFINEMENT

Template Completeness

• [x] Type — Feature
• [x] Lineage — "Depends on Drizzle setup ticket" (issue #1)
• [x] Repo — forgejo_admin/westside-admin
• [x] User Story — story-westside-admin-admin-row-crud
• [x] Context — clear motivation, swap-point design, lint enforcement rationale
• [x] File Targets — Create + Modify + Do NOT modify lists present
• [x] Acceptance Criteria — 6 ACs, behavioral + type-system + lint + comment
• [x] Test Expectations — unit + integration described
• [x] Constraints — no JWT-derived tenant_id (v1), Drizzle typed builders only
• [x] Checklist — PR / ACs / lint verification
• [x] Related — project page + arch note linked

Traceability

• [x] story:admin-row-crud label — present
• [x] story note verified — found in project-westside-admin user-stories table (story-westside-admin-admin-row-crud, Admin role, "Zero psql UPDATEs / zero fix-X texts over 30 days")
• [x] arch:scopeddb-helper label — present
• [ ] arch note MISSING — [SCOPE] No arch-scopeddb-helper note exists in pal-e-docs. The project page Architecture section lists three arch notes: arch-domain-westside-admin, arch-dataflow-westside-admin, arch-deployment-westside-admin. The issue body's Related section points to arch-dataflow-westside-admin — that is the actual backing arch note. Either (a) update the board label to arch:dataflow-westside-admin to match an existing arch note, or (b) create a dedicated arch-scopeddb-helper sub-component note. Recommend (a) since scopedDb is a layer in the data-flow diagram, not a standalone component.
• [x] type:feature label — present
• [x] Forgejo issue — https://forgejo.tail5b443a.ts.net/forgejo_admin/westside-admin/issues/3 — open

File Targets

• [~] src/lib/server/tenant.ts (Create) — path well-formed, plausible after Drizzle setup
• [~] src/lib/server/scopedDb.ts (Create) — path well-formed
• [~] src/lib/server/db.ts (Modify) — issue #1 explicitly creates src/lib/server/db.ts; consistent
• [~] package.json (Modify) — root path, will exist after scaffolding #6

Repo Placement

Dependencies

• Hard blocker: westside-admin issue #1 "Drizzle setup + drizzle-kit pull schema.ts" (board item #1089, also backlog) — creates src/lib/server/db.ts and schema.ts that this ticket modifies. Lineage line on issue body acknowledges this.
• Implicit blocker: westside-admin issue #6 "scaffolding" (board item #1087, backlog) — must create the SvelteKit project shell before #1 can run.
• Downstream: All arch:page-server tickets (#1092 issue #4, #1093 issue #5) consume scopedDb, plus the hooks-server ticket (#1090 issue #2). Shipping this ticket unblocks the entire admin row-crud surface.
• Documented? Lineage section names "Drizzle setup ticket" but does not name issue #1 or scaffolding #6. [BODY] minor: pin Lineage to "Depends on #1 (Drizzle setup), which depends on #6 (scaffolding)."

Acceptance Criteria

• AC1–AC2: SQL output assertions — verifiable by snapshot test of the generated query.
• AC3: TypeScript type error on system-table misuse — verifiable via expectTypeOf or tsc --noEmit on a negative-fixture file.
• AC4: CI lint check fails on direct db import — verifiable by running the lint script on a fixture import.
• AC5: 6+ unit tests — quantitative, easy to verify.
• AC6: multi-line swap-procedure comment in tenant.ts — verifiable via grep.

Blast Radius

• Same pattern elsewhere: basketball-api owns the source-of-truth tenant_id columns. westside-admin is the first Drizzle consumer; westside-app + westside-contracts use raw pg. No same-bug-elsewhere risk yet, but the pattern set here will inform any future Drizzle adoption.
• Downstream consumers: Every admin page-server load function (#1092, #1093) and hooks-server import (#1090) will couple to this API surface. Shipping a wrong API shape causes rebases on 3+ tickets. The decision to expose builders select / update / insert rather than a query-string helper is correct (composes with arbitrary where/and/or per the constraint), but agent should sanity-check Drizzle's actual builder API before locking signatures.
• Lint enforcement risk: A grep-based lint that fires on import { db } from '$lib/server/db' is brittle to renames or re-exports. Acceptable for v1 per the issue's framing. Flag for arch-note follow-up, not a blocker here.
• Tenant constant location: TENANT_ID = 1 in a TS file works for v1. The swap-point comment is the discipline. Acceptable.

Decomposition Assessment

Recommendation

• [SCOPE] Resolve arch:scopeddb-helper label mismatch. Either (preferred) relabel the board item to arch:dataflow-westside-admin to match the existing arch note that the issue's Related section already points to, or create a new arch-scopeddb-helper sub-component note under arch-dataflow-westside-admin. Ava's call.
• [BODY] Pin Lineage to explicit issue numbers: "Depends on #1 (Drizzle setup) which depends on #6 (scaffolding)." Helps the dev agent and downstream readers.