pal-e-docs

Re-review: E2E verify + claude.ai integration for notion-mcp-remote

review-1049-2026-04-21-v2 Review

review ready
Project

Verdict: APPROVED

Re-review of board item #1049 after label swap. Prior review review-1049-2026-04-21 returned NEEDS_REFINEMENT with one blocking [SCOPE] item (orphan arch:tailscale-funnel label) and one optional [BODY] nit. The label was swapped to arch:deployment-notion-mcp-remote. Traceability gap is resolved. Body is otherwise strong. Ticket is ready to advance.

Changes Since Prior Review

  • Board item 1049 labels now: type:feature,story:claude-ai-connect,arch:deployment-notion-mcp-remote (confirmed via list_board_items, updated_at=2026-04-21T17:42:44).
  • Prior arch:tailscale-funnel label has been removed — no longer an orphan.

Traceability

  • [x] story:claude-ai-connect label — story "Connect Notion to claude.ai"
  • [x] story note verified — story-notion-mcp-remote-claude-ai-connect listed in project-notion-mcp-remote user-stories section (unchanged from prior review)
  • [x] arch:deployment-notion-mcp-remote label — deployment architecture for the service
  • [x] arch note verified — arch-deployment-notion-mcp-remote exists in pal-e-docs, status=active, note_type=architecture. Contains the full deployment topology including the Tailscale Funnel leg (notion-mcp-remote.tail5b443a.ts.net), Harbor, Woodpecker, ArgoCD + Image Updater, Kustomize overlay, and PVC. Covers every component exercised by the E2E validation AC.
  • [x] type:feature label — appropriate (new capability validation, not a bug fix)
  • [x] Forgejo issue — forgejo_admin/notion-mcp-remote#9 — open, body unchanged and template-compliant

Template Completeness

Unchanged from prior review — all 11 template sections present (Type, Lineage, Repo, User Story, Context, File Targets, Acceptance Criteria, Test Expectations, Constraints, Checklist, Related). 11 AC map cleanly to the 6 user-story AC plus platform and recordkeeping checks.

File Targets

Not applicable — verification-only ticket. Deliverables are a validation note (per sop-validation) and a milestone mark on the project page Status section.

Repo Placement

OK. Issue filed on forgejo_admin/notion-mcp-remote, which owns the validation pass. No change.

Dependencies

Seven prerequisite tickets still in backlog (pal-e-platform#296, pal-e-services#57, pal-e-deployments#132, notion-mcp-remote#5/#6/#7/#8). Correctly documented in the Constraints section ("Do not begin this ticket until all upstream tickets closed"). The review→todo gate is independent of the execution gate; this ticket can advance to todo once upstream work is ready to start. No refinement needed.

Acceptance Criteria

11 AC unchanged and testable with concrete commands. Platform checks cover Woodpecker pipeline, ArgoCD sync+health, pod Running, /health 200, /.well-known/oauth-authorization-server JSON shape, and Prometheus scrape of notion_mcp_remote_up. E2E checks cover all 6 story AC (claude.ai URL accept, Notion OAuth < 60s, search returns real results, second tool call succeeds). Recordkeeping covers validation note + Milestone M1 mark + upstream closure.
The prior optional [BODY] nit about asserting registration_endpoint on the /.well-known AC is non-blocking and intentionally not required. Dynamic Client Registration will be implicitly exercised by the E2E AC "claude.ai accepts the connector URL" — if DCR were broken, that AC would fail. The optional nit stands as a future quality improvement but does not gate approval.

Blast Radius

Small — observational only, no config or code changes. Unchanged from prior review.

Decomposition Assessment

11 AC exceeds the default 5-AC threshold, but validation tickets are explicitly exempt — one pass must exercise every AC of the user story per sop-validation. Points=2 reflects the 15–20 min execution. No decomposition needed.

Recommendation

Verdict: APPROVED. No action needed. Ticket is ready to advance from backlog to todo when upstream dependencies are cleared.
  • Prior [SCOPE] — resolved by label swap to arch:deployment-notion-mcp-remote; backing arch note verified present.
  • Prior [BODY] nit (registration_endpoint assertion) — acknowledged, non-blocking, not required to prove AC. DCR failure mode is caught by the existing "claude.ai accepts URL" E2E AC.
  • Board item 1049 — board-notion-mcp-remote column=backlog
  • Forgejo: forgejo_admin/notion-mcp-remote#9
  • Prior review: review-1049-2026-04-21 (NEEDS_REFINEMENT — superseded)
  • arch-deployment-notion-mcp-remote
  • story-notion-mcp-remote-claude-ai-connect
  • project-notion-mcp-remote
  • sop-validation